Admin blows up when an extension has an invalid icon image and makes ALL extensions unusable

Description

We are publishing a new extension and noticed the icon path was wrong. When we click on the admin, the entire applications blows up, instead of just logging the icon error, or showing a not found icon. Right now, the entire extensions admin does not load.

The issue lies in the fact that we blantely trust the URL in the location:

Actually, the entire method needs a try/catch, to prevent from malUrls or invalid binary data in the URL

Environment

None

Activity

Show:
Michael Offner
September 2, 2019, 8:09 AM

Fixed

Assignee

Michael Offner

Reporter

Luis Majano

Priority

Blocker

Labels

Fix versions

Sprint

None

Affects versions

Configure