Issues

Select view

Select search mode

 
20 of 20

scopeContext.hasExistingCFSessionScope(pc) creates a session

Fixed

Description

getPageContext().hasCFSession() actually creates a session if one doesn’t exist

Session session = (Session) context.get(pc.getCFID());

which ends up creating a session if one doesn’t exist

As part of this, If you create a cfml session inside a cfml, we end up with double set-Cookie headers being set

Environment

None

Attachments

4

Details

Assignee

Reporter

Priority

Fix versions

New Issue warning screen

Before you create a new Issue, please post to the mailing list first https://dev.lucee.org

Once the issue has been verified, one of the Lucee team will ask you to file an issue

Sprint

Created 31 January 2025 at 12:53
Updated 20 March 2025 at 11:39
Resolved 20 March 2025 at 11:39

Activity

Show:

Pothys - MitrahSoft20 March 2025 at 11:38

I have tested this ticket with Lucee version 6.2.1.77-RC. When I checked the session CFID by executing the given test code and compared it with the older version, it is no longer creating the CFID, and it works fine now in the latest version.

Zac Spitzer11 February 2025 at 14:06

Zac Spitzer3 February 2025 at 16:59
Edited

can you do a code review, I need to rebase all the other open PRs for this epic on top of these fixes, now that internalRequest behaves like cfhttp

this solves a regression in 6.2

Zac Spitzer3 February 2025 at 16:27

other failing tests fixed

Basically they needed to actually needed force session creation and when there is only one set cookie header, it’s a string, rather than an array

Zac Spitzer3 February 2025 at 15:20

I have updated the testcase to allow additionally testing via cfhttp when running via browser

with the following two fixes, these tests now pass and perform the same via internal request and cfhttp

but fixing this, broke some existing tests (expected)

Flag notifications