Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Diff member function for dateDiff incompatible with ACF

Description

The diff member function as implemented in lucee operates inversely to the ACF implementation, so the same code will produce a positive number on one engine and a negative number on the other.

Here is an example:
https://trycf.com/gist/df4796e9f5252d781b104ebb2da3f595/lucee5
https://trycf.com/gist/df4796e9f5252d781b104ebb2da3f595/acf2018

The code:

date1 = '2018-10-10'; writeOutput(dateDiff('d', '2018-10-10', '2018-10-25')); diffDate = dateAdd('d', 0, date1); writeOutput(diffDate.diff('d', '2018-10-25'));

Outputs `1515` on lucee and `15-15` on ACF.

Activity

Show:

Pothys - MitrahSoft 22 November 2021 at 09:48

I've checked this ticket on the lucee latest build 6.0.0.132-SNAPSHOT and now dateDiff(), date.diff() returns result same as ACF.

https://github.com/lucee/Lucee/commit/5e90010329863992bb331379c73bae6c6b9248f7

Michael Offner 19 November 2021 at 15:44

please give that new build a try

Zac Spitzer 9 May 2019 at 16:29

Can somebody with rights add the acf-compat label to this?

Michael Offner 9 May 2019 at 15:31

not really sure we should follow ACF here, ACF seem to turn left and right around.

in addition fixing this will cause issues for existing code depending on the existing functionality, means if we change it we cannot do it before 6.0, we do no changse in minor release that change functionality of existing code.

 

Pothys - MitrahSoft 23 October 2018 at 15:15

I've added test case & Confirmed the issue happened on lucee. I've fixed this issue. ACF returns as expected but lucee returns always positive result while using member function for calculating a differences between two different dates.

Pull request: https://github.com/lucee/Lucee/pull/595

Fixed

Details

Assignee

Reporter

Labels

New Issue warning screen

Before you create a new Issue, please post to the mailing list first https://dev.lucee.org

Once the issue has been verified, one of the Lucee team will ask you to file an issue

Sprint

Fix versions

Affects versions

Priority

Parent

Created 19 October 2018 at 14:50
Updated 8 June 2023 at 08:49
Resolved 22 November 2021 at 09:48

Flag notifications