Administrator.updateDatasource() issues creating MSSQL datasource

Description

The Administrator.updateDatasource() has some minor bugs, even in v5.3.

  1. The code to parse the "custom" keys is wrong and does not match the code in the administrator.

  2. When trying to create an MSSQL database, it appears the API needs to add the custom key "databaseName". For some reason this gets added in the UI, but not via the API (although I don't see where in the code it's being added.

This is what my patch looks like based on the v5.3 of the Administrator.cfc:

Environment

CentOS 7/Apache 2.4

Activity

Show:

Pothys - MitrahSoft 31 August 2020 at 12:29
Edited

, Yes, I've checked it and it works fine as expected.

Michael Offner 31 August 2020 at 11:55

please give the build a try and report here.

Michael Offner 31 August 2020 at 11:53

Pothys - MitrahSoft 22 July 2020 at 15:57

, I've checked this ticket with lucee latest version 5.3.8.17-SNAPSHOT also. Yes, there is no databasename in the connection string while creating a Datasource via API for MSSQL. But check with UI, there is a databasename available. So I created a PR.

Pull Request: https://github.com/lucee/Lucee/pull/986

Fixed

Details

Assignee

Reporter

Priority

Labels

Fix versions

New Issue warning screen

Before you create a new Issue, please post to the mailing list first https://dev.lucee.org

Once the issue has been verified, one of the Lucee team will ask you to file an issue

Sprint

Affects versions

Created 21 July 2020 at 18:33
Updated 27 April 2021 at 14:25
Resolved 31 August 2020 at 12:29