Administrator.updateDatasource() issues creating MSSQL datasource

Description

The Administrator.updateDatasource() has some minor bugs, even in v5.3.

  1. The code to parse the "custom" keys is wrong and does not match the code in the administrator.

  2. When trying to create an MSSQL database, it appears the API needs to add the custom key "databaseName". For some reason this gets added in the UI, but not via the API (although I don't see where in the code it's being added.

This is what my patch looks like based on the v5.3 of the Administrator.cfc:

Environment

CentOS 7/Apache 2.4

Activity

Show:
Pothys - MitrahSoft
July 23, 2020, 1:57 AM

, I've checked this ticket with lucee latest version 5.3.8.17-SNAPSHOT also. Yes, there is no databasename in the connection string while creating a Datasource via API for MSSQL. But check with UI, there is a databasename available. So I created a PR.

Pull Request: https://github.com/lucee/Lucee/pull/986

Michael Offner
August 31, 2020, 9:53 PM

Michael Offner
August 31, 2020, 9:55 PM

please give the build a try and report here.

Pothys - MitrahSoft
August 31, 2020, 10:29 PM
Edited

, Yes, I've checked it and it works fine as expected.

Fixed

Assignee

Michael Offner

Reporter

Dan Switzer, II

Priority

New

Labels

Fix versions

Sprint

5.3.8 Sprint 3

Affects versions