debugging casts numbers to strings

Description

if you dump out a debugging log to json, you'll see lots of numbers as strings

https://github.com/lucee/Lucee/blob/5.3/core/src/main/java/lucee/runtime/debug/DebuggerImpl.java#L480

is this necessary?

Environment

None

Activity

Show:
Zac Spitzer
October 13, 2020, 7:45 AM
Edited

using set with trustType = true could also reduce the overhead of debugging logging

public Object set(int row, Object value, boolean trustType) throws DatabaseException {

https://github.com/lucee/Lucee/blob/5.3/core/src/main/java/lucee/runtime/type/QueryColumnImpl.java#L330

Pothys - MitrahSoft
October 13, 2020, 3:15 PM

I've checked this ticket and confirmed numbers come as a string, and also checked with zac's PR, and works fine but he misses some fields. I added that and create a PR too.

Pull Request: https://github.com/lucee/Lucee/pull/1069

Michael Offner
October 15, 2020, 3:15 PM

I adapted your PR but did change it a little bit

Michael Offner
October 20, 2020, 8:00 AM
Edited

is that solved in the latest version? if so please add the details here

Pothys - MitrahSoft
October 20, 2020, 3:21 PM

I've checked this ticket with latest version 5.3.8.84-SNAPSHOT. And still some number values (history ID, Pages Id) come as string values. I've added that fix in my PR https://github.com/lucee/Lucee/pull/1069.

Assignee

Michael Offner

Reporter

Zac Spitzer

Priority

New

Fix versions

Affects versions

Configure