Allow Controler validation of datasource connections to be disabled

Description

Lucee's controler thread validates every connection on every datasource every minute regardless of your timeout settings. This can cause a lot of traffic when you have a lot of datasources, and the validation is inside a syncronized method as explained in ticket https://luceeserver.atlassian.net/browse/LDEV-3124

Provide a setting to disable the every-minute validation checks. The validation flag can still be enabled on the datasource which will validate the connection before it is used.

Activity

Show:
Michael Offner
October 30, 2020, 5:33 PM

env variiable to influence this will be

Michael Offner
October 30, 2020, 5:41 PM

Brad Wood
October 30, 2020, 9:03 PM

I see the new flag, but there is a problem where it's never actually being used!

The validate param to this method needs to actually be influencing this if statement so the isValidEL() call is skipped when validate is false.

https://github.com/lucee/Lucee/blob/5.3/core/src/main/java/lucee/runtime/db/DCStack.java#L163

Michael Offner
November 2, 2020, 9:16 AM

added the missing check

Brad Wood
November 2, 2020, 5:31 PM

Looks good Thanks for letting me review it!!

Fixed

Assignee

Brad Wood

Reporter

Brad Wood

Labels

None

Fix versions

Priority

New