Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

cfQuery is not Threadsafe! [pageContext / TimeZone]

Description

cfQuery rewrites pageContext TimeZone temporary inside the Thread and sets it back at finish.

If you run some Querys inside more than one Thread. For example in two Threads. The local pageContext TimeZone is overwritten with the wrong value

Lucee Server Timezone: [EUROPE/BERLIN]
Datasource Timezone: [UTC]

Example:

Result:
After the two Thread the pagecontext.timezone is now UTC and not Europe/Berlin

Environment

Linux

  • Apache

  • Mysql

Mysql Timezone [UTC]
Linux Timezone [UTC]
Lucee Server Timezone [Europe/Berlin]
Mysql DataSource Timezone [UTC]

Attachments

2

Activity

Show:

mh_strait 29 June 2021 at 08:28
Edited

Version with the Bug:

5.3.3.62 → 5.3.7.48
5.3.8.0 → 5.3.8.109

 

Version without the Bug:

5.3.8.110 → 5.3.8.189

 

Fixed with the commit LDEV-3147 - add function clearTimeZone

core/src/main/java/lucee/runtime/PageContextImpl.java:3367

David Raschper 28 June 2021 at 16:07

The problem occures when you set the lucee instance to eg. Europe/Berlin and set the datasource timezone to utc.

Than it could happen (on concurrent querys) that the wrong timezone is set back to the pagecontext.

https://github.com/lucee/Lucee/blob/5.3.8.189/core/src/main/java/lucee/runtime/tag/Query.java
L: 495/496 Changes the timezone of the pagecontext to the datasource one
L: 798 Set back the timezone to the previous one
This process can fail on concurrent querys due the pagecontext for the second thread gets the utc timezone from the pagecontext and than set it back to utc later.

Zac Spitzer 28 June 2021 at 15:46

my mysql datasource timezone is set to same as lucee instance (I’m also in berlin, testing on windows)

i couldn’t quite see how your example was even meant to affect the pageContent timezone. I added in two test setTimezones, I guess your own example was a bit more complex?

as you are in a thread you should be using scoped variables, i.e. for qTest1

David Raschper 28 June 2021 at 15:35

Yes, we get another output.
First datetime is EU/Berlin but the dump at the bottom gets utc.

Did you have set a different datasource timezone?

I will test with the latest versions tomorrow.

Zac Spitzer 28 June 2021 at 15:24
Edited

I’m not quite sure what this is meant to be showing? this is with 5.3.8.189 (5.3.3 is quite old)

Unresolved

Details

Assignee

Reporter

Priority

Labels

Fix versions

New Issue warning screen

Before you create a new Issue, please post to the mailing list first https://dev.lucee.org

Once the issue has been verified, one of the Lucee team will ask you to file an issue

Affects versions

Created 28 June 2021 at 14:48
Updated 29 June 2021 at 10:47