Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

update provider publishing huge invalid zip files

Description

causing forgebox publishing to fail
https://github.com/Ortus-Lucee/forgebox-cfengine-publisher/actions/runs/3478027328/jobs/5814889871#step:5:24

Processing 5.3.10-SNAPSHOT+93 Light ... Downloading http://update.lucee.org/rest/update/provider/forgebox/5.3.10.93-SNAPSHOT?light=true ... Uploading lucee/lucee/5.3.10.93-SNAPSHOT/cf-engine-5.3.10.93-SNAPSHOT-light.zip ... Java heap space Java heap space Java heap space Java heap space ERROR (5.4.2+00453) Array index [1] out of range, array size is [0] /__w/forgebox-cfengine-publisher/forgebox-cfengine-publisher/task.cfc: line 158 156: .redLine( e.message ) 157: .redLine( e.detail ) 158: .redLine( e.tagContext[ 1 ].template & ':' & e.tagContext[ 1 ].line ) 159: .toConsole(); 160: called from /root/.CommandBox/cfml/system/modules_app/task-commands/models/TaskService.cfc: line 93

Environment

None

Attachments

1
  • 16 Nov 2022, 09:53 am

Activity

Show:

Zac Spitzer 17 November 2022 at 13:34
Edited

ahhh, that lock fix works :)

Problem was also with 5.3.8, I had backported the upload to s3 stuff within the ant build, but I hadn’t removed the old GHA build triggers, so it was indeed overlapping build requests,

I have removed the duplicate GHA triggers from the 5.3.8 build https://github.com/lucee/Lucee/commit/6c89a52e89b430629ed91300d53f55fdb8d3c888

Zac Spitzer 17 November 2022 at 12:57

Zac Spitzer 16 November 2022 at 11:31

i’d suggest we

  1. add an exclusive lock around https://github.com/lucee/lucee-data-provider/blob/master/update/S3.cfc#L210

  2. update the zip extension to latest

  3. use a temp subdir dir for each version

Zac Spitzer 16 November 2022 at 10:08

the update provider really needs to check if the produced zip files are valid, before uploading to s3

Fixed

Details

Assignee

Reporter

Priority

Labels

New Issue warning screen

Before you create a new Issue, please post to the mailing list first https://dev.lucee.org

Once the issue has been verified, one of the Lucee team will ask you to file an issue

Created 16 November 2022 at 09:53
Updated 25 November 2022 at 13:44
Resolved 25 November 2022 at 13:44

Flag notifications