Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

DateDiff with a datepart of "w" (Weekdays) gives the number of weeks between two dates instead of Weekdays

Description

Problem Description:
When using the DateDiff function with a datepart of "w" (Weekdays), you get the number of weeks between the two dates instead of Weekdays between the two dates. This is exactly the same as using a date part of "ww" (Weeks). The docs are weird because they say "w: Weekdays (same as ww)". My guess is this was originally a bug and then the docs were just updated to reflect the bug instead of just fixing it or something.

Steps to Reproduce:
<cfscript>
weeks = dateDiff("w","2016-06-11","2016-06-21");
WriteDump(weeks);
</cfscript>

http://trycf.com/gist/619f940e10314c161b9f71917417d066/lucee5?theme=monokai

Actual Result:
1

Expected Result:
7

Any Workarounds:
Build your own Weekdays function

Environment

None

Attachments

1

Activity

Show:

Michael Offner 22 October 2018 at 06:46

by driving users away from "w" and give the the chance to change their code, we can change the behaviour of "w" in Lucee 5.4 or 6. But changing the language in a way that affects existing code within a simple release (5.3.1->5.3.2) is not an option. People should be able to update with a minimal risk to break their code. Specially when the "break" will ot be uncovered by most users an we know most people do NOT read the release notes.

Thank for pointing out the typos, it is already fixed

Dan Murphy 19 October 2018 at 18:03

I see what you're saying with not wanting to break existing code and trying to match ACF. Not sure if I agree with the implementation of wd instead of fixing w or with steering people away from w. But I only have my own codebase to worry about and not the language as a whole.

shrug

Regardless, you have a couple of typos in your debug message (e.g. - it's should be its, breakig should be breaking).

Michael Offner 19 October 2018 at 16:47

Michael Offner 19 October 2018 at 15:54

in case you are using

in your code, Lucee will output the following message in the debugging output.

Michael Offner 19 October 2018 at 14:39

ok, i see now the reason for the change in ACF, function like dateAdd that are using most likely java.util.Calendar in ACF (they do in Lucee) do interpret "w" as weekday and "ww" as weeks, that seems to be the reason for the change.
I'm still not sure if we should follow this, because this could break existing code in a terrible way.

my suggestion is to keep "w" and "ww" as they are for the moment and add "wd" as a new option, that way you can use weekdays and we do not break existing code. we could even throw an exception for any code that uses "w" with an explanation why this is no longer supported.

Fixed

Details

Assignee

Reporter

Priority

Fix versions

New Issue warning screen

Before you create a new Issue, please post to the mailing list first https://dev.lucee.org

Once the issue has been verified, one of the Lucee team will ask you to file an issue

Sprint

Affects versions

Created 14 June 2016 at 03:23
Updated 1 April 2019 at 20:29
Resolved 19 October 2018 at 16:54