server update crashes when lucee can't connect to internet or lucee webservices down

Description

  • turn off wifi / internet

  • on localhost, restart service, open the lucee server admin

  • open services update in admin

then if you enable wifi, the bad result seems to be cached and it still crashes if you reload

line 92, a check is made to see if updateData.otherVersions exists
https://github.com/lucee/Lucee/blob/5.3/core/src/main/cfml/context/admin/services.update.cfm#L92

then on line 109 it just assumes it's defined
https://github.com/lucee/Lucee/blob/5.3/core/src/main/cfml/context/admin/services.update.cfm#L109

The update logic needs to be made more robust when the lucee webservices are down or unreachable

https://dev.lucee.org/t/update-page-error-key-otherversions-doesnt-exist/5563/3

Environment

None

Activity

Show:
Michael Offner
July 23, 2019, 7:00 PM

Michael Offner
July 23, 2019, 7:00 PM

sorry i missed your PR, i did more or less the same

Zac Spitzer
July 23, 2019, 7:25 PM

No worries, thanks for fixing, I'll test and report any issues

Zac Spitzer
July 24, 2019, 11:13 AM

when offline, the updates page says this, instead of showing the connection error message?

there’s a missing key [serverfailed]

 

Michael Offner
July 29, 2019, 2:22 PM

Fixed

Assignee

Michael Offner

Reporter

Zac Spitzer

Priority

Critical

Labels

Fix versions

Sprint

None

Affects versions

Configure