server update crashes when lucee can't connect to internet or lucee webservices down

Description

  • turn off wifi / internet

  • on localhost, restart service, open the lucee server admin

  • open services update in admin

then if you enable wifi, the bad result seems to be cached and it still crashes if you reload

line 92, a check is made to see if updateData.otherVersions exists
https://github.com/lucee/Lucee/blob/5.3/core/src/main/cfml/context/admin/services.update.cfm#L92

then on line 109 it just assumes it's defined
https://github.com/lucee/Lucee/blob/5.3/core/src/main/cfml/context/admin/services.update.cfm#L109

The update logic needs to be made more robust when the lucee webservices are down or unreachable

https://dev.lucee.org/t/update-page-error-key-otherversions-doesnt-exist/5563/3

Environment

None

Attachments

2

Activity

Show:

Michael Offner 29 July 2019 at 14:22

Zac Spitzer 24 July 2019 at 11:13

when offline, the updates page says this, instead of showing the connection error message?

there’s a missing key [serverfailed]

 

Zac Spitzer 23 July 2019 at 19:25

No worries, thanks for fixing, I'll test and report any issues

Michael Offner 23 July 2019 at 19:00

sorry i missed your PR, i did more or less the same

Michael Offner 23 July 2019 at 19:00

Fixed

Details

Assignee

Reporter

Priority

Fix versions

New Issue warning screen

Before you create a new Issue, please post to the mailing list first https://dev.lucee.org

Once the issue has been verified, one of the Lucee team will ask you to file an issue

Sprint

Affects versions

Created 31 May 2019 at 13:00
Updated 29 July 2019 at 14:24
Resolved 29 July 2019 at 14:24